Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

test(tests): improve coverage, fix issues and errors in tests, cleanup #1819

Merged
merged 5 commits into from
Feb 13, 2020

Conversation

MatthewDorner
Copy link
Contributor

Fixes #1804 partially

  • Add better coverage for GeneralInformation that tests both editable and non-editable functionality
  • Cleanup and standardize component test code
  • Add assertions for Thunk actions using mock store's store.getActions() as described here https://medium.com/@philihp/testing-a-redux-connected-component-with-thunk-actions-with-enzyme-41be4cc0bdce
  • Standardized naming of Redux actions such as getAppointmentStart to fetchAppointmentStart so actions that fetch data are named fetch consistently
  • Removed i18n log messages from test output
  • Removed some warnings from test output, but not all

@vercel
Copy link

vercel bot commented Feb 11, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/83l4ylayb
✅ Preview: https://hospitalrun-frontend-git-fork-matthewdorner-improve-tests.hospitalrun.now.sh

@vercel vercel bot temporarily deployed to Preview February 11, 2020 20:07 Inactive
@vercel
Copy link

vercel bot commented Feb 11, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@MatthewDorner
Copy link
Contributor Author

Test failing looks like a timezone issue. I'll look into it.

@matteovivona matteovivona changed the title test(tests): improve coverage, fix issues and errors in tests, cleanup WIP test(tests): improve coverage, fix issues and errors in tests, cleanup Feb 12, 2020
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Feb 12, 2020
@matteovivona matteovivona added this to In progress in Version 2.0 via automation Feb 12, 2020
@matteovivona matteovivona added this to the v2.0.0 milestone Feb 12, 2020
@matteovivona
Copy link
Contributor

@MatthewDorner I put WIP on title so we know that is still on "working", ok?

@MatthewDorner
Copy link
Contributor Author

Sure. I think it's just having the same test issue as the other PRs are at this time. Once that is resolved, I think this will pass.

@matteovivona matteovivona changed the title WIP test(tests): improve coverage, fix issues and errors in tests, cleanup test(tests): improve coverage, fix issues and errors in tests, cleanup Feb 13, 2020
@matteovivona matteovivona merged commit 6c9a018 into HospitalRun:master Feb 13, 2020
Version 2.0 automation moved this from In progress to Done Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
Version 2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Cleanup logs in tests
2 participants