This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
feat: added successful alert when adding new appointments #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added successful alert when adding new appointments. Replicated successful alert from new patients process and added the successful property on the translation file re HospitalRun#1894
|
|
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/3n3bkozto |
jackcmeyer
suggested changes
Mar 13, 2020
Comment on lines
+45
to
+49
| Toast( | ||
| 'success', | ||
| t('Success!'), | ||
| `${t('scheduling.appointment.successfullyCreated')} ${newAppointment.id}`, | ||
| ) |
There was a problem hiding this comment.
Could we add a test to make sure that the toast is getting called and has the proper message?
matteovivona
added
the
in progress
…into feature/success-message-new-appointment
Added test for toast when a new appointment is created successfully re HospitalRun#1894
…sotous/hospitalrun-frontend into feature/success-message-new-appointment
jackcmeyer
approved these changes
Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added successful alert when adding new appointments. Replicated successful alert from new patients process and added the successful property on the translation file.
Fixes #1894
Changes proposed in this pull request:
index.tswhich belongs toenUstranslations forscheduling, in order to display correctly the successful message.NewAppointment.tsxfile. The functiononNewAppointmentSaveSuccess, was modified by adding atoastto it after thehistory.pushprocess ends successfully.**There were not new dependencies added.