Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(authentication): POC Login System #2137

Merged
merged 43 commits into from
Jun 23, 2020
Merged

feat(authentication): POC Login System #2137

merged 43 commits into from
Jun 23, 2020

Conversation

jackcmeyer
Copy link
Member

@jackcmeyer jackcmeyer commented Jun 18, 2020

Changes proposed in this pull request:

  • refactors HospitalRun to use one local db (adds relational-pouch to help with this)
  • adds pouchdb-authentication for authentication helper
  • adds example Docker setup to connect to remote db (and a docker compose file to launch this db)

My main goals in this PR were:

  • to create some resemblance of login/logout against PouchDB/CouchDB so we can iterate on it
  • to create some login/logout so we can start work on user based things (i.e. user preferences)
  • refactor the db to use one db so we can start working on connecting the application to the server

What this pull request doesn't do

  • gracefully handle logout. Ideally we clear the localdb, or make it unaccessible some how.
  • add tests for the Login screen (I anticipate this is going to change, so I felt that adding tests for this POC did not have much value)
  • gracefully handle a session expiring (right now, if a user signed in via hospital run, but then ended their session in fauxton, HospitalRun would not gracefully handle that). Ideally, on the next user action, it would log them out.
  • in any shape or form create a production ready login system
  • connect permissions to couchdb

For things that this PR does not address, we should open new issues when this PR is merged.

What is left to finish this PR?

  • configure staging.hospitalrun.io to connect to some remote couchdb instance
  • ensure that the documentation is clear
  • fix translations

Newly added dependencies with Bundlephobia links:

@jackcmeyer jackcmeyer added the 🚀enhancement an issue/pull request that adds a feature to the application label Jun 18, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Jun 18, 2020
@jackcmeyer jackcmeyer requested review from fox1t, matteovivona and a user June 18, 2020 02:58
@gitpod-io
Copy link

gitpod-io bot commented Jun 18, 2020

@vercel
Copy link

vercel bot commented Jun 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/4f2zh9gqr
✅ Preview: https://hospitalrun-frontend-git-authentication.hospitalrun.vercel.app

@github-actions
Copy link

Size Change: 0 B

Total Size: 0 B

compressed-size-action

@vercel vercel bot temporarily deployed to Preview June 18, 2020 04:23 Inactive
@vercel vercel bot temporarily deployed to Preview June 22, 2020 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview June 22, 2020 16:09 Inactive
@vercel vercel bot temporarily deployed to Preview June 22, 2020 16:24 Inactive
@vercel vercel bot requested a deployment to Preview June 22, 2020 16:43 Abandoned
@vercel vercel bot requested a deployment to Preview June 22, 2020 16:51 Abandoned
@vercel vercel bot requested a deployment to Preview June 22, 2020 16:51 Abandoned
@vercel vercel bot requested a deployment to Preview June 23, 2020 08:29 Abandoned
@vercel vercel bot requested a deployment to Preview June 23, 2020 09:59 Abandoned
@vercel vercel bot temporarily deployed to Preview June 23, 2020 18:55 Inactive
@matteovivona matteovivona merged commit eef04c5 into master Jun 23, 2020
Version 2.0 automation moved this from In progress to Done Jun 23, 2020
@matteovivona matteovivona deleted the authentication branch June 23, 2020 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application
Projects
Version 2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants