Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(labs): alert when lab updated/completed #2258

Closed
wants to merge 7 commits into from
Closed

feat(labs): alert when lab updated/completed #2258

wants to merge 7 commits into from

Conversation

anyapawar
Copy link
Contributor

@anyapawar anyapawar commented Jul 28, 2020 •
edited by jackcmeyer

Fixes #2169

@jsf-clabot
Copy link

jsf-clabot commented Jul 28, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@gitpod-io
Copy link

gitpod-io bot commented Jul 28, 2020 •
edited

This was referenced Jul 28, 2020
Closed
Closed
@jackcmeyer jackcmeyer changed the title Toast for Lab Updated and Lab Competed feat(labs): alert when lab updated/completed Jul 29, 2020
@vercel
Copy link

vercel bot commented Jul 29, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/oe891mtzf
✅ Preview: https://hospitalrun-frontend-git-fork-anyapawar-labtoasts.hospitalrun.vercel.app

jackcmeyer
jackcmeyer suggested changes Jul 29, 2020
View reviewed changes
Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new translation keys need to be added to the files in the locales folder so that they can be translated.

@jackcmeyer
Copy link
Member

Need to fix failing tests ☺. Please let me know if you need any help.

@jackcmeyer jackcmeyer added labs issue/pull request that interacts with labs module 🚀enhancement an issue/pull request that adds a feature to the application labels Jul 29, 2020
@jackcmeyer jackcmeyer added this to In progress in Version 2.0 via automation Jul 29, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Jul 29, 2020
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Jul 30, 2020
@anyapawar anyapawar closed this Aug 10, 2020
Version 2.0 automation moved this from In progress to Done Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackcmeyer jackcmeyer jackcmeyer requested changes

Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Display success toast when lab is successfully updated
4 participants
@anyapawar @jsf-clabot @jackcmeyer @matteovivona