This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
refactor(labs): refactor labs module to use react query #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/jwbb1xlnz |
matteovivona
added
the
in progress
jackcmeyer
changed the title
jackcmeyer
suggested changes
Sep 21, 2020
|
@rsousaj there are conflicts to resolve |
jackcmeyer
approved these changes
Sep 24, 2020
|
Working on this... Next few hours will be done |
blestab
suggested changes
Sep 24, 2020
|
Hi @rsousaj looks like we have a failing test as well. May you take a look at that. |
blestab
added
labs
Sure I'll |
…rontend into issue_2339_labs_module_react_query
jackcmeyer
approved these changes
Sep 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2339 .
Changes proposed in this pull request:
Added those hooks and respective tests:
-- useLab
-- useLabsSearch
-- useRequestLab
-- useCancelLab
-- useUpdateLab
-- useCompleteLab
Remove lab-slice and labs-slice.
Updated ViewLab, ViewLabs and NewRequestLab tests
Refactor Labs.test
Refactor usePatient parameters to be optional and use useQuery config ({ enabled: id }) to only execute when id is available. This was due to ViewLab needs to execute both useLab and usePatient as dependency and because of that usePatient needs to wait for useLab to execute.
Refactor CareGoalTab.test and CarePlanTab.test to use Route as it's necessary for usePatient return data
Remove lab and labs reducers