Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scope Labels #102

Closed

Conversation

carolromero
Copy link

🎩 What? Why?

Update Scope labels for Hospitalet.
Changed 'Àmbit' for 'Barri'

📌 Related Issues

📋 Subtasks

📷 Screenshots (optional)

Description

👻 GIF

@mrcasals
Copy link
Contributor

mrcasals commented Feb 7, 2017

Hi @carolromero!

Thanks for your PR 😄 There are a few problems with it, though:

  1. The PR should be created against the master branch. Right now it's being created against Remove name and phone fields from public surveys #101 and it might get in a weird state if Remove name and phone fields from public surveys #101 is merged before this one.
  2. The translations system uses a special way in order to find the correct key. In this case, we should be overwriting the decidim.proposals.proposals.filters.scope. I understand this is not easy to deduce without the development environment set up :(

If you don't mind, I'll close this issue and reopen it myself fixing this 😄

Thanks for your contribution though! 😄

@mrcasals mrcasals closed this Feb 7, 2017
@mrcasals mrcasals deleted the change-scope-label-cat branch February 7, 2017 09:40
@mrcasals mrcasals mentioned this pull request Feb 7, 2017
@mrcasals
Copy link
Contributor

mrcasals commented Feb 7, 2017

Fixed at #104 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants