Add email field to csv presenter #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasals
approved these changes
Feb 15, 2017
ItsGenis
approved these changes
Feb 15, 2017
oriolgual
requested changes
Feb 15, 2017
| @@ -40,7 +43,10 @@ def headers | |||
| def fields | |||
| @surveys.map do |survey| | |||
| CSV.generate_line( | |||
| [survey.categories.map {|c| c.name[I18n.locale.to_s] }.join(";")].concat( | |||
| [ | |||
| survey.user.email, | |||
There was a problem hiding this comment.
Not all surveys have a user, use survey&.user&.email
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=======================================
Coverage 97.36% 97.36%
=======================================
Files 22 22
Lines 342 342
=======================================
Hits 333 333
Misses 9 9
Continue to review full report at Codecov.
|
oriolgual
approved these changes
Feb 15, 2017
|
I proceed to merge this pr, since the test are passing correctly, but codecov is down and breaking travis CI process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR adds the email field to the CSV presenter, so when the admin user'll download the Survey results it will be on it.
📌 Related Issues
📷 Screenshots (optional)
👻 GIF