-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hd.list proxy functions #36
Comments
Yes, all reasonable methods will need to be implemented eventually, but Knockout is not our guide here. Consult MDN for standard array methods[^1] and provide the same interface. We want to provide some simple helpers beyond the standard interface. I implemented [^1] Note that |
I implemented the
My |
That functionality should be folded into |
- Closes HotDrink#38, HotDrink#36 Conflicts: lib/model/proxies/array.js
Knockout has implemented the standard array functions for their
ko.observableArray
such aspush
,pop
,unshift
,shift
,reverse
,sort
, etc. (see ko documentation).Hotdrink only has
push
,pop
,remove
forhd.list
. I have already implementedremoveAll
andsort
. Should I continue to implement these functions so that Hotdrink is on par with Knockout in this area?The text was updated successfully, but these errors were encountered: