-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSLint test #34
JSLint test #34
Conversation
Don't put JSLint into the repository. Just assume the user has it installed, and add the appropriate commands to the Makefile so that it is run on every build. Once that is done, the branch can start work on fixing all the errors. |
The jslint errors are as follows: === hotdrink.js === ERRORS: 341:96 Line too long. raid.error("lib/utility/publisher.js:6: " + "new publisher already has property: " + f); --- 363:15 Unexpected 'in'. Compare with undefined, or use the hasOwnProperty method instead. if (!(evt in subscribers)) { --- 382:15 Unexpected 'in'. Compare with undefined, or use the hasOwnProperty method instead. if (!(evt in this.subscribers)) { --- 581:3 Unexpected 'hd'. hd.__private.Variable = Variable; --- 581:3 Stopping. (14% scanned). ===
Even after adding
|
A semicolon is missing from the preceding statement. |
using [node](github.com/joyent/node) and [node-jslint](github.com/philipvr/node-jslint)
I have fixed most of the jslint errors, but main thing that jslint still has a problem with is the use of
|
Could you follow the suggestion and convert them all to use |
Conflicts: lib/model/runtime/runtime.js lib/model/solver/solver.js lib/utility/publisher.js
You can now run JSLint via command line: