Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vite dependency in web #12

Closed
wants to merge 1 commit into from

Conversation

yzernik
Copy link

@yzernik yzernik commented Feb 14, 2022

No description provided.

@HotPotatoC
Copy link
Owner

Hello, thanks for the PR. Quick question, why should vite not be in the devDependency? When I scaffold the vite app it is listed as a dev dependency by default. Things might have changed and I might have missed out on it. thank you

@yzernik
Copy link
Author

yzernik commented Feb 14, 2022

I was running into an issue where the build would fail with:
sh: vite: command not found

after I run docker-compose up.

The issue resolved after I moved it out of devDependencies and based on this comment:
vitejs/vite#1215 (comment)

@HotPotatoC
Copy link
Owner

Hi sorry for the late reply.

I'm still quite unsure if vite should be moved out of devDependencies since it's a tool for development. For now, I'm keeping this PR open for alternative solutions. Also, I'm working on a rewrite of twitter clone since the codebase is quite a mess. Thanks for your time.

@yzernik yzernik closed this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants