Issues/issue 113 #150
Issues/issue 113 #150
Conversation
There was a problem hiding this comment.
@ketangarala Please review the comments in the code and respond.
| @@ -112,7 +112,7 @@ private List<SavedItemViewModel> PrepItems(List<WishListItem> items) | |||
| foreach (var item in items) | |||
| { | |||
| var p = HccApp.CatalogServices.Products.FindWithCache(item.ProductId); | |||
|
|
|||
| item.ProductShortDescription = p.Options.CartDescription(item.SelectionData.OptionSelectionList); | |||
There was a problem hiding this comment.
@ketangarala I don't see any defensive coding here for when the product doesn't have any choices/variants selected. Shouldn't you be checking for that, and only executing this line of code when there is relevant selection data?
There was a problem hiding this comment.
@hismightiness We checked CartDescription at that time, There is condition to check if option is null then return string.empty. That was the reason we did not put condition p.Hasoption(). I also agree that we should add this condition so that in future if any changes will come in to the core method CartDescription we are fine with this area. I will put condition and generate new pull request.
| @@ -112,7 +112,10 @@ private List<SavedItemViewModel> PrepItems(List<WishListItem> items) | |||
| foreach (var item in items) | |||
| { | |||
| var p = HccApp.CatalogServices.Products.FindWithCache(item.ProductId); | |||
| item.ProductShortDescription = p.Options.CartDescription(item.SelectionData.OptionSelectionList); | |||
| if (p.HasOptions()) | |||
There was a problem hiding this comment.
This will always be true if the product has options, regardless to whether any have been selected prior to adding it to the cart or wish list. You'll need to evaluate item.SelectionData.OptionSelectionList instead.
There was a problem hiding this comment.
@ketangarala This is still an issue.
There was a problem hiding this comment.
As per your Suggestion item.SelectionData.OptionSelectionList is replaced in condition to check nullable and code is Committed , so please check last committed change.
To Show Selection Data of Product into WishList new property called "ProductShortDescription" Added in WishListItem Class.