Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #184 SI: Don't notify customers in AssignMembershipRole method of DnnMembershipServices class #197

Merged
merged 3 commits into from
Jun 1, 2019
Merged

PR #184 SI: Don't notify customers in AssignMembershipRole method of DnnMembershipServices class #197

merged 3 commits into from
Jun 1, 2019

Conversation

sniravj
Copy link
Contributor

@sniravj sniravj commented May 27, 2019

No description provided.

@sniravj sniravj requested a review from WillStrohl May 27, 2019 12:14
@WillStrohl WillStrohl merged commit 33e0509 into development Jun 1, 2019
@WillStrohl WillStrohl added this to the 03.02.02 milestone Jun 1, 2019
@WillStrohl WillStrohl deleted the Issues/Issue-184 branch June 1, 2019 22:40
@WillStrohl
Copy link
Member

@sniravj I just tested this and it doesn't work. The Notify setting is not saved to the database and therefore is always disabled since this is the default for the data column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillStrohl WillStrohl Awaiting requested review from WillStrohl

Assignees

@WillStrohl WillStrohl

Labels
enhancement Task
Milestone
03.02.02
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sniravj @WillStrohl