Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #354 - Reverting Redirect changes #355

Closed

Conversation

Navilois
Copy link
Contributor

@Navilois Navilois commented Apr 8, 2021

Fixes #354

Revert "All Controllers: changed every occurrence of Response.Redirect to Redirect"

This reverts commit 5fa3a90.

@erw13n
Copy link
Contributor

erw13n commented Sep 9, 2021

Don't revert the change that been made.
Response.Redirect is causing a lot of error on event logs as reported in #112 and hotcakes forum

The implementation of Redirect was wrong, it should be "return Redirect" instead of "Redirect"

Related to #368

@WillStrohl WillStrohl closed this Nov 30, 2021
@WillStrohl
Copy link
Member

This PR cannot be accepted as-is. It breaks numerous checkout workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CheckoutController -> LoadCheckoutModel: Redirect not working if CurrentCart == null
3 participants