Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #292 - Affiliate & Category (drilldown) views don't work #359

Merged
merged 10 commits into from
Dec 1, 2021

Conversation

erw13n
Copy link
Contributor

@erw13n erw13n commented Apr 28, 2021

Fix #292 include :

  • Javascript issue due missing validation for Confirm Terms
  • Term Popup show nothing event if affiliate agreement terms been fill in

Tested on :

  • Default Theme
  • Porto Theme

@WillStrohl WillStrohl added this to the 03.06.00 milestone Apr 29, 2021
@WillStrohl WillStrohl added the bug label Apr 29, 2021
@@ -166,9 +166,12 @@ public string ToJson()
[RegularExpression(@"[-\w]*", ErrorMessage = "Only alpha-numeric and '-', '_' characters are allowed")]
public string ReferralAffiliateId { get; set; }

public bool IsTrue => true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to a standard property. The build process won't recognize this version of C# (right now).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erw13n I don't see your update on this one yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, I'll update it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already update it, its on commit of "Update the other Viewset" below.

@erw13n
Copy link
Contributor Author

erw13n commented Apr 29, 2021

OK, I'll update the other viewset.

@WillStrohl
Copy link
Member

Please see the other code review note as well. This PR is blocked right now. :(

@@ -166,7 +166,7 @@ public string ToJson()
[RegularExpression(@"[-\w]*", ErrorMessage = "Only alpha-numeric and '-', '_' characters are allowed")]
public string ReferralAffiliateId { get; set; }

public bool IsTrue => true;
public bool IsTrue { get { return true; } }
Copy link
Contributor Author

@erw13n erw13n Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillStrohl It's been update in here.

Copy link
Contributor Author

@erw13n erw13n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillStrohl This commit contain change for other viewset: MyBootstrap3, MyLegacy, MyViewset, Porto5 & SocialSpokes

@WillStrohl WillStrohl merged commit 569512a into HotcakesCommerce:development Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

SI: Viewset Affiliate & Category (drilldown) views don't work
2 participants