Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not force CodeLens (or explain it well) #145

Closed
langpavel opened this issue Dec 12, 2018 · 3 comments
Closed

Do not force CodeLens (or explain it well) #145

langpavel opened this issue Dec 12, 2018 · 3 comments

Comments

@langpavel
Copy link
Contributor

langpavel commented Dec 12, 2018 •
edited
Loading

Hi
you are forcing VSCode users to:

  "typescript.referencesCodeLens.enabled": true,
  "javascript.referencesCodeLens.enabled": true,

As I can imagine — it can be very powerful tool. But it doesn't work for me and I must explicitly disable it.

Will be much better to instruct people how to turn this on instead of letting us (scratching on the head) what is that 0 references disturbing line…
@langpavel langpavel changed the title CodeLens Do not force CodeLens (or explain it well) Dec 12, 2018
@Hotell
Copy link
Owner

Hotell commented Dec 12, 2018

Hmm, purpose of this package is not to explain code editor configuration and what it does.
I'll provide option in new init script, which will ask user if they wanna include vscode recommended settings for this library. that's all what I can do and it's right IMHO, if it helps :)

@langpavel
Copy link
Contributor Author

langpavel commented Dec 12, 2018 •
edited
Loading

That CodeLens are explicitly enabled by your starter.
I suggest no force, you can kindly recommend in README

@Hotell Hotell mentioned this issue Dec 12, 2018
Merged
Hotell added a commit that referenced this issue Dec 12, 2018
@Hotell
feat(scripts): implement init script (#143)
53be637 
* feat(scripts): use init on postinstall
* feat(scripts): add vscode settings prompt
* ci: use latest yarn
* ci: don't run postinstall on CI
* chore: bump deps
* refactor: use ambient fiels for local types
* feat(templates): add templates and their setup
* feat(config): add replace-in-file types
* fix(scripts): fix init files modifications
* fix(scripts): fix templates setup
* feat(scripts): add additional prompt questions
* fix(scripts): properly handle vscode setup
* fix(scripts): initialize hooks properly
* ci: fix yarn install
* fix(scripts): resolve ts errors
* feat(vscode): add more settings
* fix(scripts): use githubName in readme template
* docs: add setup video
* feat: add index barrel tsd like header
* refactor(scripts): reorder modifyFiles array

BREAKING CHANGE:
Now TS >= 3 is used which may break some packages that desperately need to support lower versions

Closes #142 #145 #130
@Hotell
Copy link
Owner

Hotell commented Dec 12, 2018

Closed by #143

@Hotell Hotell closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@langpavel @Hotell