Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul forcefield parameters for ions #15

Merged
merged 68 commits into from
Dec 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
e5f823b
add minimal support for merz and TIP4PFB water model
rkingsbury Jun 22, 2021
8d92e55
add stiff bonds to water models for energy min
rkingsbury Jun 23, 2021
d7bb5e1
fix typo in tip4p_fb water charge
rkingsbury Jun 25, 2021
1986725
Merge branch 'main' of https://github.com/htz1992213/mdgo into ions_l…
rkingsbury Jun 29, 2021
eb58865
Merge branch 'main' of https://github.com/htz1992213/mdgo into ions_l…
rkingsbury Jul 1, 2021
79501e1
Merge branch 'main' of https://github.com/htz1992213/mdgo into ions_l…
rkingsbury Jul 3, 2021
a6a2d48
Merge branch 'main' of https://github.com/htz1992213/mdgo into ions_l…
rkingsbury Jul 16, 2021
f5487c7
fix ion conversion mistake; add Na+
rkingsbury Jul 16, 2021
6d27e7e
Merge branch 'main' of https://github.com/htz1992213/mdgo into ions_l…
rkingsbury Jul 19, 2021
7cec2f0
Merge branch 'main' of https://github.com/htz1992213/mdgo into ions_l…
rkingsbury Jul 19, 2021
34dfa67
Merge branch 'main' of https://github.com/htz1992213/mdgo into ions_l…
rkingsbury Jul 19, 2021
83e510a
Merge remote-tracking branch 'tz/main' into ions_latest
rkingsbury Jul 21, 2021
cfac13d
correct units of epsilon in tip4pfb; add tip3pfb
rkingsbury Jul 21, 2021
9b38320
overhaul ion parameter sets
rkingsbury Jul 22, 2021
c93d2d7
organize imports
rkingsbury Jul 22, 2021
0fc4e7f
bugfixes
rkingsbury Jul 22, 2021
6c6b389
add minimal support for merz and TIP4PFB water model
rkingsbury Jun 22, 2021
f5100ee
add stiff bonds to water models for energy min
rkingsbury Jun 23, 2021
b4569a8
fix typo in tip4p_fb water charge
rkingsbury Jun 25, 2021
19d81dd
fix ion conversion mistake; add Na+
rkingsbury Jul 16, 2021
8e3a47d
correct units of epsilon in tip4pfb; add tip3pfb
rkingsbury Jul 21, 2021
c789aab
overhaul ion parameter sets
rkingsbury Jul 22, 2021
17057cd
organize imports
rkingsbury Jul 22, 2021
6d973be
Merge branch 'main' of https://github.com/htz1992213/mdgo into ions_l…
rkingsbury Sep 18, 2021
cfbdb3b
Merge branch 'ions_latest' of https://github.com/rkingsbury/mdgo into…
rkingsbury Sep 19, 2021
33b8d70
linting
rkingsbury Oct 13, 2021
9f6632a
Packmol: overhaul and add tests
rkingsbury Oct 13, 2021
770e805
add'l tests and fix for spaces in path name
rkingsbury Oct 13, 2021
f5a0f4a
add info message if packmol not installed
rkingsbury Oct 13, 2021
2d97856
Merge branch 'ions_latest' of https://github.com/rkingsbury/mdgo into…
rkingsbury Oct 27, 2021
bda0f73
add OPC and OPC3 water models
rkingsbury Oct 27, 2021
d4c286b
change ion param storage; add tests
rkingsbury Oct 27, 2021
010d699
restore FFCrawlerTest
rkingsbury Oct 27, 2021
715eaab
rm text files for ion parameters
rkingsbury Oct 27, 2021
c6bc1dc
add packmol
htz1992213 Nov 11, 2021
ce26532
change actions working directory
htz1992213 Nov 11, 2021
6877693
fortran compile error
htz1992213 Nov 11, 2021
76e45cf
made executable
htz1992213 Nov 11, 2021
3bbe527
test actions
htz1992213 Nov 11, 2021
8fa7033
test actions 2
htz1992213 Nov 11, 2021
5b53589
test actions 3
htz1992213 Nov 11, 2021
46be06b
test actions 4
htz1992213 Nov 11, 2021
347a607
test actions 5
htz1992213 Nov 11, 2021
346983c
test actions 6
htz1992213 Nov 11, 2021
22eceda
test actions 7
htz1992213 Nov 11, 2021
5ad8390
identified test_random_seed
htz1992213 Nov 11, 2021
8569dcf
bump up python (3.8); fix typo
htz1992213 Nov 11, 2021
d469e30
Update lint.yml
htz1992213 Nov 11, 2021
839da3e
Revert "Update lint.yml"
htz1992213 Nov 11, 2021
1e178ed
Revert "bump up python (3.8); fix typo"
htz1992213 Nov 11, 2021
4d6bddb
fix typo
htz1992213 Nov 11, 2021
6798cdd
using Literal with typing-extensions
htz1992213 Nov 11, 2021
9e8279b
Update tests/test_mdgopackmol.py
rkingsbury Nov 16, 2021
0803df1
Update tests/test_mdgopackmol.py
rkingsbury Nov 16, 2021
43b3c2c
Update tests/test_mdgopackmol.py
rkingsbury Nov 16, 2021
c919ad2
Update tests/test_mdgopackmol.py
rkingsbury Nov 16, 2021
d430a90
Packmol: test file case error, rm spurious quotes
rkingsbury Nov 16, 2021
b38ff56
Merge branch 'ions_latest' of https://github.com/rkingsbury/mdgo into…
rkingsbury Nov 16, 2021
7d80e09
Merge branch 'packmol' into ions_latest
rkingsbury Nov 16, 2021
1220e32
Add mixing_rule kwarg
rkingsbury Nov 22, 2021
7a5e543
add mixing_rule logic
rkingsbury Nov 22, 2021
a778920
add WATER_SIGMA to support mixing rules
rkingsbury Nov 22, 2021
f32d78c
Ions: update .json with formula bugfix
rkingsbury Nov 22, 2021
f41f215
rearrange Aqueous.get_ion kwargs
rkingsbury Nov 23, 2021
61f62bf
black
rkingsbury Nov 23, 2021
4559d24
modify get_ion signature; add tests for mixing rule
htz1992213 Nov 30, 2021
8674a6e
lint
htz1992213 Nov 30, 2021
796d49a
bump up pymatgen
htz1992213 Dec 14, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ jobs:
pip install -r requirements.txt
pip install -r requirements-dev.txt
pip install -e .
- name: Prepare Packmol
run: |
echo $HOME
echo "$HOME/work/mdgo/mdgo/tests/packmol" >> $GITHUB_PATH
- name: Prepare Selenium
# https://github.com/marketplace/actions/setup-chromedriver
uses: nanasess/setup-chromedriver@master
Expand Down
152 changes: 152 additions & 0 deletions docs/source/aqueous.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,152 @@

================================
Force Fields for Aqueous Systems
================================

The Aqueous module provides tools for setting up molecular dynamics simulations
involving water and ions.

Water Models
============

`mdgo` contains parameters for several popular water models. This section lists
a brief description and literature reference to the available models.

SPC
---

TIP3P-EW
--------

TIP3P-FB
--------

Wang, L., Martinez, T. J., Pande, V.S., Building Force Fields: An Automatic, Systematic,
and Reproducible Approach. J. Phys. Chem. Lett. 2014, 5, 11, 1885–1891.
https://pubs.acs.org/doi/abs/10.1021/jz500737m

Parameters are given in Supporting Table 1. Note that the epsilon for Oxygen must be converted
from kJ/mol to kcal/mol.

TIP4P-EW
--------

[Vega & de Miguel, J Chem Phys 126:154707 (2007), Vega et al, Faraday Discuss 141:251 (2009)].

TIP4P-FB
--------

Wang, L., Martinez, T. J., Pande, V.S., Building Force Fields: An Automatic, Systematic,
and Reproducible Approach. J. Phys. Chem. Lett. 2014, 5, 11, 1885–1891.
https://pubs.acs.org/doi/abs/10.1021/jz500737m

Parameters are given in Supporting Table 1. Note that the epsilon for oxygen must be converted
from kJ/mol to kcal/mol.

TIP4P-2005
----------

Abascal & Vega, J Chem Phys 123:234505 (2005)

OPC
----

Izadi, Anandakrishnan, and Onufriev, Building Water Models: A Different Approach.
J. Phys. Chem. Lett. 2014, 5, 21, 3863–3871 https://doi.org/10.1021/jz501780a

Parameters are given in Table 2. Note that the epsilon for oxygen must be converted
from kJ/mol to kcal/mol.

OPC3
----

Izadi and Onufriev, Accuracy limit of rigid 3-point water models
J. Chemical Physics 145, 074501, 2016. https://doi.org/10.1063/1.4960175

Parameters are given in Table II. Note that the epsilon for oxygen must be converted
from kJ/mol to kcal/mol.


Ion Parameter Sets
==================

``mdgo`` contains a compilation of several sets of Lennard Jones
parameters for ions in water. All values are reported as :math:`\sigma_i`
and :math:`\epsilon_i` in the equation

.. math::

E = 4 \\epsilon_i \\left[ \\left( \\frac{\sigma_i}{r} \\right)^{12} - \\left( \\frac{\sigma_i}{r} \\right)^{6} \\right]

Values of :math:`\sigma_i` and :math:`\epsilon_i` are given in Angstrom
and kcal/mol, respectively, corresponding to the ‘real’ units system in
LAMMPS.

Aqvist (aq)
-----------

Aqvist, J. Ion-Water Interaction Potentials Derived from Free Energy
Perturbation Slmulations J. Phys. Chem. 1990, 94, 8021– 8024.
https://pubs.acs.org/doi/10.1021/j100384a009

Values were parameterized to the SPC water model and are reported in
Table I and II as :math:`A_i` and :math:`B_i` coefficients in the
following form of the Lennard-Jones potential:

.. math::


E = \left[ \left( \frac{A_i^2}{r} \right)^{12} - \left( \frac{B_i^2}{r} \right)^{6} \right]

This parameter set is a work in progress!

Jensen and Jorgensen (jj)
-------------------------

Jensen, K. P. and Jorgensen, W. L., Halide, Ammonium, and Alkali Metal
Ion Parameters for Modeling Aqueous Solutions. J. Chem. Theory Comput.
2006, 2, 6, 1499–1509. https://pubs.acs.org/doi/abs/10.1021/ct600252r

Values were parameterized to the TIP4P water model using geometric
combining rules and are reported directly as sigma_i and epsilon_i in
Table 2.

Joung-Cheatham (jc)
-------------------

Joung, and Thomas E. Cheatham, Thomas E. III, Determination of Alkali
and Halide Monovalent Ion Parameters for Use in Explicitly Solvated
Biomolecular Simulations. J. Phys. Chem. B 2008, 112, 30, 9020–9041.
https://pubs.acs.org/doi/10.1021/jp8001614

Values were parameterized for the SPC/E, TIP3P, and TIP4P_EW water
models using Lorentz-Berthelot combining rules (LAMMPS: ‘arithmetic’)
and are reported in Table 5 as :math:`R_{min}`/2 and epsilon_i. R_min/2
values are converted to :math:`\sigma_i` values using
:math:`\sigma_i = R_{min}/2 * 2^(5/6)`

Li and Merz group (lm)
----------------------

Sengupta et al. Parameterization of Monovalent Ions for the OPC3, OPC,
TIP3P-FB, and TIP4P-FB Water Models. J. Chem. Information Modeling
61(2), 2021. https://pubs.acs.org/doi/10.1021/acs.jcim.0c01390

Li et al. Systematic Parametrization of Divalent Metal Ions for the
OPC3, OPC, TIP3P-FB, and TIP4P-FB Water Models. J. Chem. Theory and
Computation 16(7), 2020.
https://pubs.acs.org/doi/10.1021/acs.jctc.0c00194

Li et al. Parametrization of Trivalent and Tetravalent Metal Ions for
the OPC3, OPC, TIP3P-FB, and TIP4P-FB Water Models. J. Chem. Theory and
Computation 17(4), 2021.
https://pubs.acs.org/doi/10.1021/acs.jctc.0c01320

Values were parameterized for the OPC, OPC3, TIP3P-FB, and TIP4P-FB
water models using Lorentz-Berthelot combining rules (LAMMPS:
‘arithmetic’) and are reported in Table 3 as :math:`R_{min}`/2 and
epsilon_i. R_min/2 values are converted to :math:`\sigma_i` values using
:math:`\sigma_i = R_{min}/2 * 2^(5/6)`. This set of values is optimized
for reproducing ion-oxygen distance. An alternate set of values optimized for
hydration free energies is available in the original papers.

22 changes: 0 additions & 22 deletions mdgo/data/ion/aqvist/Ba++.lmp

This file was deleted.

22 changes: 0 additions & 22 deletions mdgo/data/ion/aqvist/Ca++.lmp

This file was deleted.

22 changes: 0 additions & 22 deletions mdgo/data/ion/aqvist/Cs+.lmp

This file was deleted.

22 changes: 0 additions & 22 deletions mdgo/data/ion/aqvist/K+.lmp

This file was deleted.

22 changes: 0 additions & 22 deletions mdgo/data/ion/aqvist/Li+.lmp

This file was deleted.

22 changes: 0 additions & 22 deletions mdgo/data/ion/aqvist/Mg++.lmp

This file was deleted.

22 changes: 0 additions & 22 deletions mdgo/data/ion/aqvist/Na+.lmp

This file was deleted.

22 changes: 0 additions & 22 deletions mdgo/data/ion/aqvist/Rb+.lmp

This file was deleted.

22 changes: 0 additions & 22 deletions mdgo/data/ion/aqvist/Sr++.lmp

This file was deleted.

22 changes: 0 additions & 22 deletions mdgo/data/ion/jensen_jorgensen/Br-.lmp

This file was deleted.

Loading