-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Duplicate virtual +layout.js
files
#1053
Conversation
🦋 Changeset detectedLatest commit: 742a748 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Name | Link |
---|---|
🔨 Latest commit | 742a748 |
✅ Deploy Preview for houdini-docs-next ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this together! Mind running prettier really quickly?
Done! |
Duplicate
+layout.js
files were being created in the root directory. This was an issue without side effects until sveltekit 1.15.5, which added a duplicate check. This fix allows houdini to work in sveltekit again.To help everyone out, please make sure your PR does the following:
pnpm run tests
andcd integration && pnpm run tests
pnpm changeset