Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Duplicate virtual +layout.js files #1053

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

knd775
Copy link
Sponsor Contributor

@knd775 knd775 commented Apr 13, 2023

Duplicate +layout.js files were being created in the root directory. This was an issue without side effects until sveltekit 1.15.5, which added a duplicate check. This fix allows houdini to work in sveltekit again.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2023

🦋 Changeset detected

Latest commit: 742a748

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
houdini-svelte Patch
houdini-plugin-svelte-global-stores Patch
houdini-react Patch
houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 13, 2023

‼️ Deploy request for houdinigraphql rejected.

Name Link
🔨 Latest commit 742a748

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for houdini-docs-next ready!

Name Link
🔨 Latest commit 742a748
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/643984b4fbae480008e19bb9
😎 Deploy Preview https://deploy-preview-1053--houdini-docs-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@AlecAivazis AlecAivazis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this together! Mind running prettier really quickly?

@knd775
Copy link
Sponsor Contributor Author

knd775 commented Apr 14, 2023

Thanks for getting this together! Mind running prettier really quickly?

Done!

@AlecAivazis AlecAivazis enabled auto-merge (squash) April 14, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants