Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when structured values are used for fragment variables #1169

Merged
merged 3 commits into from
Sep 23, 2023

Conversation

AlecAivazis
Copy link
Collaborator

Fixes #1165

This PR fixes a bug when fragment variables were set to structured elements

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2023

🦋 Changeset detected

Latest commit: c76852f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
houdini Patch
houdini-adapter-cloudflare Patch
houdini-plugin-svelte-global-stores Patch
houdini-react Patch
houdini-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 23, 2023

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit c76852f
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/650e665353e2010008185b7e

@netlify
Copy link

netlify bot commented Sep 23, 2023

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit c76852f
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/650e6653ecb942000809b659

@AlecAivazis AlecAivazis changed the title tests pass Fix bug when structured values are used for fragment variables Sep 23, 2023
@AlecAivazis AlecAivazis enabled auto-merge (squash) September 23, 2023 04:26
@AlecAivazis AlecAivazis merged commit 41e3bdb into main Sep 23, 2023
16 checks passed
@AlecAivazis AlecAivazis deleted the fragment-variable-non-scalars branch September 23, 2023 04:26
@github-actions github-actions bot mentioned this pull request Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fragment arguments with arguments other than a scalar breaks
1 participant