Fix houdini-svelte crashing the Svelte LSP #1293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1292
So it turns out that
fs.statSync
takes in astring | Buffer | URL
as path - the last of which does not have a.includes()
function. (https://nodejs.org/docs/v20.11.1/api/fs.html#fsstatsyncpath-options)Occasionally it is passed an
URL
, which then causes an error which bubbles up and causes the svelte LSP to crash. This PR fixes the fsPatchstatSync
function to properly handle this.To help everyone out, please make sure your PR does the following:
pnpm run tests
andcd integration && pnpm run tests
pnpm changeset