Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in error path #1296

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Fix memory leak in error path #1296

merged 4 commits into from
Apr 25, 2024

Conversation

AlecAivazis
Copy link
Collaborator

@AlecAivazis AlecAivazis commented Apr 13, 2024

This PR fixes a memory leak in the cache that was found as part of the investigation into #1294. This PR does not fix the original issue since it requires some additional thinking and there is a work-around

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Apr 13, 2024

🦋 Changeset detected

Latest commit: e5240df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
houdini Patch
houdini-adapter-auto Patch
houdini-adapter-cloudflare Patch
houdini-adapter-node Patch
houdini-react Patch
houdini-svelte Patch
houdini-plugin-svelte-global-stores Patch
create-houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit e5240df
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/6629f215aade93000837a2f1

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit e5240df
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/6629f215b9ec5f00071880fa

@AlecAivazis AlecAivazis merged commit e636868 into main Apr 25, 2024
15 checks passed
@AlecAivazis AlecAivazis deleted the error-memory-leak branch April 25, 2024 06:10
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants