Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unmarshalling lists of custom scalars from the cache #1322

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

SeppahBaws
Copy link
Collaborator

Fixes #1321

The marshalling step already had an extra check to marshal the individual values if it encountered an array. The unmarshalling step, however, was not invited to the party and just passed the raw values from the cache to the unmarshalling handler in the config.
Now the unmarshalling step has been invited and will pass the individual values of arrays to the proper unmarshall handler in the user's config.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 3c17473

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
houdini Patch
houdini-adapter-auto Patch
houdini-adapter-cloudflare Patch
houdini-adapter-node Patch
houdini-react Patch
houdini-svelte Patch
houdini-plugin-svelte-global-stores Patch
create-houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit 3c17473
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/668c76b0d86c8000089b0d64

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit 3c17473
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/668c76b07cc7370008a7cc57

@SeppahBaws SeppahBaws enabled auto-merge (squash) July 8, 2024 23:33
Copy link
Collaborator

@AlecAivazis AlecAivazis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@SeppahBaws SeppahBaws merged commit c9a019d into main Jul 8, 2024
14 checks passed
@SeppahBaws SeppahBaws deleted the unmarshal-scalars-list branch July 8, 2024 23:41
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmarshalling lists of scalars not working
2 participants