Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inject the service locator instance into all SL-aware fixtures on add #30

Closed
wants to merge 4 commits into from

Conversation

ontario
Copy link

@ontario ontario commented Jun 26, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) when pulling 500cf83 on ontario:master into 1a3571c on Hounddog:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) when pulling cc6ca92 on ontario:master into 1a3571c on Hounddog:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) when pulling bac4f6a on ontario:master into 1a3571c on Hounddog:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) when pulling 1919b68 on ontario:master into 1a3571c on Hounddog:master.

@Ocramius
Copy link
Collaborator

Why was the package renamed? As for the service locator aware interface, I already said before that the injection MUST happen in the constructor. Setter injection is NO-NO.

@Ocramius Ocramius closed this Jun 27, 2014
@Ocramius Ocramius self-assigned this Jun 27, 2014
@ontario
Copy link
Author

ontario commented Jun 27, 2014

Package renamed? Oh, sorry. That is my wrong. How I can do injection in the constructor?

@Ocramius
Copy link
Collaborator

@ontario it's already handled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants