Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bevy plugin does not create a checksum for the state anymore #20

Open
james7132 opened this issue Jul 16, 2021 · 2 comments
Open

Bevy plugin does not create a checksum for the state anymore #20

james7132 opened this issue Jul 16, 2021 · 2 comments
Labels
breaking change This will require at least a minor version bump

Comments

@james7132
Copy link
Member

As of 014fd15, bevy_backroll is now saving the provided state without any hashing/checksum. This could lead to silent desyncs as no checksum checks will fail in these cases. We should look for a generic way of handling this without reintroducing the Hash bound on Config::State.

@james7132 james7132 added the breaking change This will require at least a minor version bump label Jul 16, 2021
@ValorZard
Copy link
Contributor

A jank way we can do it is maybe giving all possible data a unique id? So like, hitbox transform is 25 or something. And then we add it all together for a checksum? That probably wouldn't work though...

@ErnWong
Copy link

ErnWong commented Jul 16, 2021

Just to bounce some more ideas around...

Perhaps we could introduce a BackrollChecksum trait, which is a weaker version of the Hash trait that is automatically implemented for objects that implement Hash, but allows us to extend it to generate checksums for common bevy data structures that are not covered by Hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This will require at least a minor version bump
Projects
None yet
Development

No branches or pull requests

3 participants