Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/add console to error handler #78

Merged
merged 5 commits into from
Mar 19, 2023

Conversation

Howard86
Copy link
Owner

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix -> missing logging error when handling errors

  • What is the current behavior? (You can also link to an open issue here)

    When there's an error sent to next-api-handler, it only shows caught errors without further debugging info

  • What is the new behavior (if this is a feature change)?

    • Refactor log message from a centralised private logHandler method and control logging level and message
    • Add error.trace for non-HttpException errors
  • Other information:

@vercel
Copy link

vercel bot commented Mar 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
next-api-handler-example ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 19, 2023 at 6:50PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
next-api-handler ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2023 at 6:50PM (UTC)

@cypress
Copy link

cypress bot commented Mar 19, 2023

Passing run #139 ↗︎

0 10 0 0 Flakiness 0

Details:

null
Project: next-api-handler Commit: 1cabc8374c
Status: Passed Duration: 00:08 💡
Started: Mar 19, 2023 6:51 PM Ended: Mar 19, 2023 6:51 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codeclimate
Copy link

codeclimate bot commented Mar 19, 2023

Code Climate has analyzed commit 1cabc83 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #78 (1cabc83) into main (7bfc5d7) will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   99.46%   99.84%   +0.37%     
==========================================
  Files           8        8              
  Lines         566      636      +70     
  Branches       71       85      +14     
==========================================
+ Hits          563      635      +72     
+ Misses          3        1       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Howard86 Howard86 merged commit 2abc4c2 into main Mar 19, 2023
@Howard86 Howard86 deleted the bugfix/add-console-to-error-handler branch March 19, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant