Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/add cors integration #93

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Bugfix/add cors integration #93

merged 3 commits into from
Apr 18, 2023

Conversation

Howard86
Copy link
Owner

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

Fix when adding cors middleware, OPTIONS returns 405 which is unnecessary

  • What is the new behavior (if this is a feature change)?

Only run router handler if its a supported method

  • Other information:

@vercel
Copy link

vercel bot commented Apr 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-api-handler ✅ Ready (Inspect) Visit Preview Apr 18, 2023 6:12am
next-api-handler-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 6:12am

@codeclimate
Copy link

codeclimate bot commented Apr 18, 2023

Code Climate has analyzed commit e40d27e and detected 0 issues on this pull request.

View more on Code Climate.

@cypress
Copy link

cypress bot commented Apr 18, 2023

Passing run #166 ↗︎

0 10 0 0 Flakiness 0

Details:

null
Project: next-api-handler Commit: e40d27e47f
Status: Passed Duration: 00:09 💡
Started: Apr 18, 2023 6:14 AM Ended: Apr 18, 2023 6:14 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #93 (e40d27e) into main (62058c9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files           8        8           
  Lines         636      652   +16     
  Branches       85       88    +3     
=======================================
+ Hits          635      651   +16     
  Misses          1        1           

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Howard86 Howard86 merged commit a6bede5 into main Apr 18, 2023
3 checks passed
@Howard86 Howard86 deleted the bugfix/add-cors-integration branch April 18, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant