Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Func/join #80

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Func/join #80

merged 3 commits into from
Oct 8, 2019

Conversation

Navneet78
Copy link
Contributor

@Navneet78 Navneet78 commented Oct 8, 2019 •
edited
Loading

Adding A class method .join() in DOMElement Class .

@coveralls
Copy link

coveralls commented Oct 8, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 92.542% when pulling d9236be on Navneet78:func/join into 90f57f0 on Hrabal:master.

@Hrabal
Copy link
Owner

Hrabal commented Oct 8, 2019

Thank @Navneet78 !
Can you add a couple unittest in TemPy/tests/test_DOMElement.py ?

@Navneet78
Copy link
Contributor Author

yeah sure

@Hrabal
Copy link
Owner

Hrabal commented Oct 8, 2019

Thanks!

p.s: never do list = [... . . . ] or you will have no more lists in python! ;) (i'll fix that in tests...)

@Hrabal Hrabal merged commit 45916fe into Hrabal:master Oct 8, 2019
@Navneet78
Copy link
Contributor Author

Ohh, that was my bad sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Navneet78 @coveralls @Hrabal