Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css errors are noisy even with SilentCssErrorHandler enabled #378

Closed
skyhirider opened this issue Sep 3, 2021 · 3 comments
Closed

Css errors are noisy even with SilentCssErrorHandler enabled #378

skyhirider opened this issue Sep 3, 2021 · 3 comments
Assignees

Comments

@skyhirider
Copy link
Contributor

skyhirider commented Sep 3, 2021

I believe there was a regression introduced in 2.52 that is not present in 2.51 - some parsing errors are thrown and show even when silenced handlers are enabled.

On 2.51 the log is silent, on 2.52 I see exceptions in the error log which is really messy. I don't want to disable error messages completely but silencing the webclient has no effect.

catch (final Exception e) {
if (LOG.isErrorEnabled()) {
LOG.error("Error while parsing style value '" + styleAttribute + "'", e);
}
}

Link to git blame https://github.com/HtmlUnit/htmlunit/blame/master/src/main/java/com/gargoylesoftware/htmlunit/html/DomElement.java#L284

@rbri
Copy link
Member

rbri commented Sep 5, 2021

Correct, great finding! Thanks!

There is a new Snapshot build available (requires a htmlunit-cssparster snapshot). Please have a look if your problem is fixed.

@rbri rbri self-assigned this Sep 5, 2021
@skyhirider
Copy link
Contributor Author

Thanks for the quick fix, it's silent when using the snapshot. Cheers!

@rbri
Copy link
Member

rbri commented Sep 6, 2021

Thanks for the feedback, have fun using HtmlUnit.

@rbri rbri closed this as completed Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants