Allow hiding switch environment status bar item via settings #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huachao
requested changes
Dec 8, 2017
package.json
Outdated
| @@ -441,6 +441,12 @@ | |||
| "default": "full", | |||
| "scope": "resource", | |||
| "description": "Response preview output option. 'full' for whole response message(status line, headers and body). 'headers' for response headers(as well as status line). 'body' for response body only. 'exchange' for whole HTTP exchange (request and response)" | |||
| }, | |||
| "rest-client.showStatusBarItem": { | |||
There was a problem hiding this comment.
minor: how about rename it to showEnvironmentStatusBarItem, since status bar in my extension also includes response duration and size status bars
There was a problem hiding this comment.
@Huachao Sure, sounds good to me
Huachao
approved these changes
Dec 8, 2017
Huachao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is such a minor nitpick but it feels a bit distracting for me when i'm editing files that completely unrelated to REST client but that status bar switcher is always present 馃槃
This pull request adds
showStatusBarItemboolean parameter configurable from settings.Since we can switch environments via command palette anyway we aren't losing in functionality with this new config param set to
false.