Smoother agent startup/shutdown flow #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got this working smoothly now. Adding to an ALB spends a lot more time in the initializing state than with old ELBs, so had to account for the slower startup. The agents will now poll at an interval determined by the service and only fully start once they are done being added to the ELB/ALB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be the last piece needed on the ALB support side. This will grab the configured connection drain/shutdown delay for an ALB when an agent is shutting down. If the agent gets back a response of that type, it will wait until the drain time has elapsed to shut down.
/cc @PtrTeixeira