More efficient bootstrapping in BaragonAgent #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
reviewed
Oct 29, 2018
BaragonAgentService/src/main/java/com/hubspot/baragon/agent/managed/LifecycleHelper.java
Outdated
Show resolved
Hide resolved
ssalinas
reviewed
Oct 29, 2018
BaragonAgentService/src/main/java/com/hubspot/baragon/agent/managed/LifecycleHelper.java
Outdated
Show resolved
Hide resolved
ssalinas
reviewed
Oct 29, 2018
BaragonAgentService/src/main/java/com/hubspot/baragon/agent/managed/LifecycleHelper.java
Outdated
Show resolved
Hide resolved
ssalinas
reviewed
Nov 1, 2018
BaragonAgentService/src/main/java/com/hubspot/baragon/agent/managed/LifecycleHelper.java
Outdated
Show resolved
Hide resolved
ssalinas
reviewed
Nov 2, 2018
BaragonAgentService/src/main/java/com/hubspot/baragon/agent/managers/AgentRequestManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"For some of our larger groups like hubapi/privateapi, the bootstrap apply is sometimes in the range of 4-5 minutes. We need our nginx containers to be able to start up in seconds. The current method checks for configs to be valid after each is applied, rolling back those that aren't, and continuing on. The template generation itself isn't all that slow, but the repeated config validation adds up."