This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
Fix issues with namespace clashing in our interal deployer #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathanwgoodwin why not just have all |
Jw0x47
force-pushed
the
namespace-config
branch
from
6807b55
to
1a3d0c2
Compare
|
@gchomatas I've updated the PR to nest the blazar configuration inside a single property |
|
🚢 |
|
gchomatas's ship has signed off 4 commits by jgoodwin. |
aaylward
reviewed
Mar 21, 2017
| public class BlazarConfiguration extends Configuration { | ||
| /** | ||
| * The configuration for Blazar. | ||
| * All options that control how the BlazarService behaves are configured here. These are wrapped by {@Link BlazarWrapperConfiguration} |
There was a problem hiding this comment.
s/BlazarWrapperConfiguration/BlazarConfigurationWrapper ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gchomatas
Our internal fabric deploy was preventing us from deploying this because there was a config yaml namespace conflict on the key
github.Rather than deal with more config clashes in the future I opted to re-name all the blazar specific options to
blazar####so that when reading the config it is clear what properties are for the deployer and which are consumed by Blazar.