How to pull docker image from private registry using singularity custom executor?

[jaredstehler]

I'm not sure how to get the singularity executor to use credentials to pull from my private docker registry? I've authenticated successfully in docker on each of my slaves (which put the /root/.docker/config.json in each one with the auth token) but still see "Not authorized" exceptions on startup in the task log:

Caused by: com.spotify.docker.client.ImagePullFailedException: Image pull failed: maven.intellify.tools:9453/docker-intellify/pdf-service: ProgressMessage{id=null, status=null, stream=null, error=unauthorized: authentication required, progress=null, progressDetail=null}
    at com.spotify.docker.client.LoggingPullHandler.progress(LoggingPullHandler.java:41) ~[SingularityExecutor-0.7.1-shaded.jar:0.7.1]
    at com.spotify.docker.client.ProgressStream.tail(ProgressStream.java:74) ~[SingularityExecutor-0.7.1-shaded.jar:0.7.1]
    at com.spotify.docker.client.DefaultDockerClient.pull(DefaultDockerClient.java:668) ~[SingularityExecutor-0.7.1-shaded.jar:0.7.1]
    at com.spotify.docker.client.DefaultDockerClient.pull(DefaultDockerClient.java:650) ~[SingularityExecutor-0.7.1-shaded.jar:0.7.1]
    at com.hubspot.singularity.executor.utils.DockerUtils$2.call(DockerUtils.java:53) ~[SingularityExecutor-0.7.1-shaded.jar:0.7.1]
    at com.hubspot.singularity.executor.utils.DockerUtils$2.call(DockerUtils.java:51) ~[SingularityExecutor-0.7.1-shaded.jar:0.7.1]

I see that the spotify docker client says to specify credentials in an AuthConfig instance, but I don't see that anywhere in the SingularityExecutor source, so is there something simple I'm missing?

from https://github.com/spotify/docker-client :

// Pull an image from a private repository
// Server address defaults to "https://index.docker.io/v1/"
AuthConfig authConfig = AuthConfig.builder().email("foo@bar.com").username("foobar")
  .password("secret-password").serverAddress("https://myprivateregistry.com/v1/").build();
docker.pull("foobar/busybox-private:latest", authConfig);

[ssalinas]

Yeah, that's some config we still need to add. The configuration for the custom executor docker stuff is still pretty basic right now. We can add that in (or feel free to PR it!)

[jaredstehler]

Thanks for the heads up! I'll try my hand at a PR shortly.