Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SingularityMailer into an interface #1004

Merged
merged 1 commit into from
Apr 28, 2016
Merged

Conversation

jhaber
Copy link
Member

@jhaber jhaber commented Apr 19, 2016

Alternative to #1003 converts SingularityMailer into an interface and binds a no-op impl if the smtp configuration isn't present

@ssalinas
Copy link
Member

+1 thanks haber

@Calvinp
Copy link
Contributor

Calvinp commented Apr 20, 2016

+1 Much cleaner

@ssalinas
Copy link
Member

Thanks again for the fix haber, /fixes #1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants