New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SingularityMailer into an interface #1004

Merged
merged 1 commit into from Apr 28, 2016

Conversation

Projects
None yet
3 participants
@jhaber
Member

jhaber commented Apr 19, 2016

Alternative to #1003 converts SingularityMailer into an interface and binds a no-op impl if the smtp configuration isn't present

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 19, 2016

Member

+1 thanks haber

Member

ssalinas commented Apr 19, 2016

+1 thanks haber

@Calvinp

This comment has been minimized.

Show comment
Hide comment
@Calvinp

Calvinp Apr 20, 2016

Contributor

+1 Much cleaner

Contributor

Calvinp commented Apr 20, 2016

+1 Much cleaner

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 28, 2016

Member

Thanks again for the fix haber, /fixes #1001

Member

ssalinas commented Apr 28, 2016

Thanks again for the fix haber, /fixes #1001

@ssalinas ssalinas merged commit e112a35 into master Apr 28, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the mailer-interface branch Apr 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment