Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert SingularityMailer into an interface #1004

Merged
merged 1 commit into from Apr 28, 2016
Merged

Convert SingularityMailer into an interface #1004

merged 1 commit into from Apr 28, 2016

Conversation

jhaber
Copy link
Member

@jhaber jhaber commented Apr 19, 2016

Alternative to #1003 converts SingularityMailer into an interface and binds a no-op impl if the smtp configuration isn't present

@ssalinas
Copy link
Member

+1 thanks haber

@Calvinp
Copy link
Contributor

Calvinp commented Apr 20, 2016

+1 Much cleaner

@ssalinas ssalinas mentioned this pull request Apr 20, 2016
Closed
@ssalinas ssalinas modified the milestone: 0.6.0 Apr 27, 2016
@ssalinas
Copy link
Member

Thanks again for the fix haber, /fixes #1001

@ssalinas ssalinas merged commit e112a35 into master Apr 28, 2016
@ssalinas ssalinas deleted the mailer-interface branch April 28, 2016 12:52
@ssalinas ssalinas mentioned this pull request Apr 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhaber @ssalinas @Calvinp