Avoid race condition in deploy to unpause#1088
Merged
Merged
Conversation
Contributor
Author
|
This one is gtg, going to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the request status is not updated to
DEPLOY_TO_UNPAUSEbefore the deploy is saved. It is possible that the deploy checker can run the first check of the deploy while the request is still in the paused state. This code path also left the deploy in a waiting state with no message.Changes here move the request state update before the deploy save, and will also be sure to complete the deploy with a failure when hitting the code path where request state is not valid to proceed with the deploy