Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display previous overridden cleanups #1442

Merged
merged 9 commits into from Mar 16, 2017
Merged

Display previous overridden cleanups #1442

merged 9 commits into from Mar 16, 2017

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Mar 6, 2017

Right now, when a cleanup type changes we override the previous entry to change the type. It is useful to still be able to see the history of what happened. This saves previous entries in a filed on the cleanup and displays them in the ui table. They are added on a field in the entry because it would be a much larger change to try and update the zk node structure to accommodate multiple of the same type of update

/cc @darcatron


private Set<SingularityTaskHistoryUpdate> getFlattenedPreviousUpdates(SingularityTaskHistoryUpdate update) {
Set<SingularityTaskHistoryUpdate> previousUpdates = new HashSet<>();
for (SingularityTaskHistoryUpdate preivousUpdate : update.getPrevious()) {
Copy link
Contributor

@darcatron darcatron Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: sp (previousUpdate)

Copy link
Member Author

@ssalinas ssalinas Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ssalinas ssalinas modified the milestone: 0.15.0 Mar 13, 2017
@ssalinas ssalinas merged commit b337be3 into master Mar 16, 2017
@ssalinas ssalinas deleted the cleaning_message branch Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants