Display previous overridden cleanups #1442

Merged
merged 9 commits into from Mar 16, 2017

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Mar 6, 2017

Right now, when a cleanup type changes we override the previous entry to change the type. It is useful to still be able to see the history of what happened. This saves previous entries in a filed on the cleanup and displays them in the ui table. They are added on a field in the entry because it would be a much larger change to try and update the zk node structure to accommodate multiple of the same type of update

/cc @darcatron

@ssalinas ssalinas added the hs_staging label Mar 6, 2017

+
+ private Set<SingularityTaskHistoryUpdate> getFlattenedPreviousUpdates(SingularityTaskHistoryUpdate update) {
+ Set<SingularityTaskHistoryUpdate> previousUpdates = new HashSet<>();
+ for (SingularityTaskHistoryUpdate preivousUpdate : update.getPrevious()) {

This comment has been minimized.

@darcatron

darcatron Mar 10, 2017

Contributor

nit: sp (previousUpdate)

@darcatron

darcatron Mar 10, 2017

Contributor

nit: sp (previousUpdate)

This comment has been minimized.

@ssalinas

ssalinas Mar 10, 2017

Member

fixed

@ssalinas ssalinas modified the milestone: 0.15.0 Mar 13, 2017

@ssalinas ssalinas merged commit b337be3 into master Mar 16, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@ssalinas ssalinas deleted the cleaning_message branch Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment