Display previous overridden cleanups #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matush-v
reviewed
Mar 10, 2017
|
|
||
| private Set<SingularityTaskHistoryUpdate> getFlattenedPreviousUpdates(SingularityTaskHistoryUpdate update) { | ||
| Set<SingularityTaskHistoryUpdate> previousUpdates = new HashSet<>(); | ||
| for (SingularityTaskHistoryUpdate preivousUpdate : update.getPrevious()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when a cleanup type changes we override the previous entry to change the type. It is useful to still be able to see the history of what happened. This saves previous entries in a filed on the cleanup and displays them in the ui table. They are added on a field in the entry because it would be a much larger change to try and update the zk node structure to accommodate multiple of the same type of update
/cc @darcatron