Fix maxDeployIdSize and maxRequestIdSize validation#1491
Merged
ssalinas merged 1 commit intoHubSpot:masterfrom May 8, 2017
andrhamm:andrew/fix-id-validations
Merged
Fix maxDeployIdSize and maxRequestIdSize validation#1491ssalinas merged 1 commit intoHubSpot:masterfrom andrhamm:andrew/fix-id-validations
ssalinas merged 1 commit intoHubSpot:masterfrom
andrhamm:andrew/fix-id-validations
Conversation
From the docs: > Deploy ids *over* this size will cause deploy requests to fail with 400 > Request ids *over* this size will cause new requests to fail with 400 Example: If `maxDeployIdSize` is set to 50 and `deployId.length()` is 50 an error is still thrown: ``` Deploy id must be less than 50 characters, it is 50 (foobarbizbanghelloworldwhywontmyidworkthisreallyfu) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the docs:
Example: If
maxDeployIdSizeis set to 50 anddeployId.length()is 50 an error is still thrown: