New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maxDeployIdSize and maxRequestIdSize validation #1491

Merged
merged 1 commit into from May 8, 2017

Conversation

Projects
None yet
2 participants
@andrhamm
Contributor

andrhamm commented Apr 6, 2017

From the docs:

Deploy ids over this size will cause deploy requests to fail with 400
Request ids over this size will cause new requests to fail with 400

Example: If maxDeployIdSize is set to 50 and deployId.length() is 50 an error is still thrown:

Deploy id must be less than 50 characters, it is 50 (foobarbizbanghelloworldwhywontmyidworkthisreallyfu)
Fix maxDeployIdSize and maxRequestIdSize validation
From the docs:

> Deploy ids *over* this size will cause deploy requests to fail with 400
> Request ids *over* this size will cause new requests to fail with 400

Example: If `maxDeployIdSize` is set to 50 and `deployId.length()` is 50 an error is still thrown:

```
Deploy id must be less than 50 characters, it is 50 (foobarbizbanghelloworldwhywontmyidworkthisreallyfu)
```

@ssalinas ssalinas added the hs_staging label Apr 28, 2017

@ssalinas ssalinas modified the milestones: 0.15.0, 0.16.0 Apr 28, 2017

@ssalinas ssalinas merged commit 7d7add7 into HubSpot:master May 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment