Smarter table pagination #1706
Smarter table pagination #1706
Conversation
|
Do we want to hide the button or disable it? Also, should we continue to display the current page number? |
| this.setState({chunkNum, rowChunkSize, sortBy, lastPage}); | ||
| const lookaheadNum = (chunkNum * rowChunkSize) + 1; | ||
| this.setState({ lookahead: true }); | ||
| return this.props.fetchDataFromApi(lookaheadNum, 1).then((lookaheadResponse) => { |
There was a problem hiding this comment.
Is this something that we always want to do for UITable or should this be configurable. You might also want to consider doing both of these requests in parallel and using Promise.all. That might make it unnecessary to separately keep track of the lookahead request state.
There was a problem hiding this comment.
I think it makes sense in the current UITable design since it only applies to tables that have the fetchDataFromApi prop set. Do you foresee tables that have this prop set but won't have a lookahead call?
I had considered running the requests in parallel, but I thought it might be more complicated because the order of completion is undefined. Since the data prop of the UI table is supplied by the parent component and that is supplied by the requestApi object.
|
We're going to opt for better back-end support instead of making two API calls from the front-end. |
Make table pagination more obvious by fetching ahead to see if there is more data. If not, hide the "next" button.