S3 uploader + executor cleanup efficiency improvements #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
commented
Mar 19, 2020
Comment on lines
+161
to
+162
| } catch (UncheckedIOException|NoSuchFileException nsfe) { | ||
| LOG.debug("Parent file {} did not exist, skipping", directory); |
There was a problem hiding this comment.
This is because some directories we scanned contain tmp files, so even though we checked for the directory directly above this, it's possible it got deleted out from under us before we started the filesystem walk
ssalinas
commented
Mar 19, 2020
| return TaskCleanupResult.WAITING; | ||
| } | ||
|
|
||
| boolean cleanupTaskAppDirectorySuccess = cleanupTaskAppDirectory(); | ||
| boolean logTearDownSuccess = taskLogManager.teardown(); |
There was a problem hiding this comment.
This was the important line to move @baconmania . This shouldn't delete any log files, so the previous logging PR is still in effect. But it moves the task app directory cleanup to the end, so that we don't wait forever to clean logs just because we haven't cleaned taskapp yet
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In looking through the code, there was a path that could cause us to build up an unnecessary amount of open uploaders if a large count of failed tasks ended up on the same host. In the current cleanup setup, because we were preserving the task app directory, we would short circuit before hitting any lines that finalized uploaders, allowing them to run to completion in the S3Uploader. Since the task is finished, there is no reason to keep the uploader files open
This also cleans up a few noisier exceptions and log statements that aren't adding a ton of value across the different runnables