Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render page while fetching history tables #2094

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Render page while fetching history tables #2094

merged 2 commits into from
Jun 4, 2020

Conversation

pschoenfelder
Copy link
Contributor

@pschoenfelder pschoenfelder commented May 19, 2020

History tables can sometimes be slow to fetch, so we should wait to load the entire page.

My frontend knowledge here is minimal, but I think taking advantage of this should take care of the issue: https://github.com/HubSpot/Singularity/blob/timeout/SingularityUI/app/components/common/table/UITable.jsx#L439

@pschoenfelder pschoenfelder changed the title Don't wait on histories tables Render page while fetching history tables May 19, 2020
@ssalinas
Copy link
Member

@pschoenfelder this will give those pages nicer loading icons, and we can keep that However, I think the overall issue is more here:
https://github.com/HubSpot/Singularity/blob/master/SingularityUI/app/components/requestDetail/RequestDetailPage.jsx#L47-L90

in mapStateToProps there, we set the deleted boolean to true if the request returns a 404 or the history state for the request is empty. I think the Utils.maybe code in there will return an empty list for things if the request hasn't returned anything and populated the state yet. So, the active requests table doesn't try to render. We can probably have that condition be just the 404 and make sure each table can handle the empty table state properly

@ssalinas
Copy link
Member

ssalinas commented Jun 4, 2020

🚢

@ssalinas ssalinas merged commit d91ba6e into master Jun 4, 2020
@ssalinas ssalinas deleted the timeout branch June 4, 2020 16:35
@ssalinas ssalinas added this to the 1.3.0 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants