-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint to get Singularity config values #2199
Conversation
SingularityService/src/main/java/com/hubspot/singularity/resources/AgentResource.java
Outdated
Show resolved
Hide resolved
SingularityService/src/main/java/com/hubspot/singularity/resources/AbstractMachineResource.java
Outdated
Show resolved
Hide resolved
} | ||
|
||
@GET | ||
@Path("/singularity-limits-format") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick — can we change this to just /singularity-limits
?
public SingularityLimits(int maxDecommissioningAgents) { | ||
this.maxDecommissioningAgents = maxDecommissioningAgents; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't have immutables set up in Singularity, this needs a @JsonCreator
annotation on the constructor and @JsonProperty("maxDecommissioningAgents")` on the field. See other things in the Base module for examples
🚢 |
🚢 |
This PR exposes Singularity's
maxDecommissioningAgents
, defined in the config file.