Add taskId to loadbalancer upstream #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows partitioning loadbalancer upstreams per deploy
Jw0x47
commented
Jun 2, 2021
| public Optional<String> getTaskId() { | ||
| return taskId; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { |
There was a problem hiding this comment.
I didn't update HashCode / Equals since the absence / presence of this new data doesn't really impact the upstream itself; its just a reference we can use to group things by singularity deploy at the load balancing layer later on.
Since this data is likely persisted in this form without the value present adding HC / Equals would result in a change to those comparisons and likely break stuff.
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows partitioning loadbalancer upstreams per deploy.
@pschoenfelder