Support global overrides of request placement strategy/rack sensitivity #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
reviewed
Aug 26, 2021
| @@ -56,6 +56,7 @@ public void runActionOnPoll() { | |||
| lock.runWithRequestLock( | |||
| () -> { | |||
| SingularityRequest request = requestWithState.getRequest(); | |||
| // TODO - support global override here? | |||
There was a problem hiding this comment.
we can probably ignore for this spread all case, it should just continue to try and scale to whatever remains
ssalinas
reviewed
Aug 26, 2021
There was a problem hiding this comment.
Two overall comments:
- not sure if this belongs in the RackResource or not? I'm wondering if we need a new/separate AdminConfigurationResource or something like that? There is also the DisastersResource that has a hodge-podge of emergency action endpoints
- should the endpoint just allow us to globally set the PlacementStrategy, vs defaulting everything to OPTIMISTIC based on a boolean? Wondering if we'd ever need GREEDY vs OPTIMISTIC
WH77
force-pushed
the
live-configuration
branch
from
97a3d21
to
69e8eac
Compare
SingularityService/src/main/java/com/hubspot/singularity/config/SingularityConfiguration.java
Outdated
Show resolved
Hide resolved
...Service/src/main/java/com/hubspot/singularity/mesos/SingularityMesosStatusUpdateHandler.java
Outdated
Show resolved
Hide resolved
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exists to speed up response/recovery time in the event of a rack outage, via new API endpoints that will set global configuration overrides of request placement strategy and/or rack sensitivity on the current leader.