Prevent accidental large scale downs #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
reviewed
Mar 25, 2022
Comment on lines
1248
to
1256
| checkBadRequest( | ||
| !scaleDownExceedsAbsoluteMax, | ||
| "Cannot scale down by more than %s instances at a time", | ||
| 10 | ||
| ); | ||
| checkBadRequest( | ||
| !(previousScale.get() > 10 && scaleDownExceedsRelativeMax), | ||
| "Cannot scale down by more than half of current instances." | ||
| ); |
There was a problem hiding this comment.
Can these err messages have '...without explicit acknowledgement' or something like that on them? Make it obvious what field has to be set
ssalinas
reviewed
Mar 25, 2022
|
|
||
| if (previousScale.isPresent() && !request.getLargeScaleDownAcknowledged()) { | ||
| boolean scaleDownExceedsAbsoluteMax = | ||
| previousScale.get() - request.getInstancesSafe() > 10; |
There was a problem hiding this comment.
Should we make the 10 configurable? Think that's my only other comment on this one. Easier to change yaml and redeploy than to rebuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely open to different logic, thresholds, etc. Just wanted to get something out here to start a discussion around.