Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning to Disable Healthchecks for < 1 Hour #851

Merged
merged 2 commits into from Jan 28, 2016
Merged

Conversation

@Calvinp
Copy link
Contributor

Calvinp commented Jan 20, 2016

Some processes need a decent chunk of time to go from zero to healthy.
If the healthchecks run before the process is healthy, which may happen when tasks are in a bad state, problems could occur.
This change posts a warning and requires a second confirmation to disable healthchecks for less than one hour.

…sable healthchecks for less than an hour.
@ssalinas ssalinas added the hs_staging label Jan 20, 2016
@ssalinas ssalinas added hs_qa labels Jan 22, 2016
@tpetr tpetr modified the milestone: 0.4.9 Jan 27, 2016
ssalinas added a commit that referenced this pull request Jan 28, 2016
Warning to Disable Healthchecks for < 1 Hour
@ssalinas ssalinas merged commit 61b9a32 into master Jan 28, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
@ssalinas ssalinas deleted the disable-healthcheck-warning branch Jan 28, 2016
@ssalinas ssalinas removed hs_qa labels Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.