Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating favicon to reference brand_settings #479

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Updating favicon to reference brand_settings #479

merged 1 commit into from
Apr 28, 2023

Conversation

jasonnrosa
Copy link
Member

Types of change

  • Bug fix (change which fixes an issue)
  • Enhancement (change which improves upon an existing feature)
  • New feature (change which adds new functionality)

Description

Updating favicon to reference brand_settings instead of site_settings as that will be the new preferred location to pull from.

Checklist

joeyblake
joeyblake approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@joeyblake joeyblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but from looking at some other discussion I think I understand whats going on here. otherwise LGTM!

src/templates/layouts/base.html Show resolved Hide resolved
@jasonnrosa jasonnrosa merged commit 738799b into main Apr 28, 2023
@jasonnrosa jasonnrosa deleted the update-branding branch April 28, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyblake joeyblake joeyblake approved these changes

@bran-van-d bran-van-d Awaiting requested review from bran-van-d

@jazzyclimber jazzyclimber Awaiting requested review from jazzyclimber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasonnrosa @joeyblake