Handle intersecting mutations #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2017 14:43
…urn length of prefix or suffix. enhance updateMutation with more descriptive names of conditions and the ability to check for partially intersecting mutations where one is modified with a prefix/suffix, and splits the other mutation into two parts. add tests from @liyantang
This was referenced Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My stab at fixing #46.
Address styles that intersect with entities that have a prefix/suffix conversion strategy by splitting the style's mutation into two ranges - one inside the entity's tag, one outside. I also added some better naming to conditions in
updateMutationto make it more readable.Thanks to @liyantang for pushing the ball forward here and for the tests which I included in this PR. One of the ended up outputting a slightly different nesting order but I believe it should still be equivalent.