Remove Modules.override to allow other ServletModules to be installed in the injector #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the GuiceBundle and JerseyContainerModule so that JerseyContainerModule no longer relies on Modules.override to swap the Dropwizard WebApplication for the standard Jersey one. Using Modules.override prevents other ServletModules from being installed in the DI container.
eliast
added a commit
that referenced
this pull request
Apr 18, 2013
Remove Modules.override to allow other ServletModules to be installed in the injector
|
I also need support for multiple ServletModules for Shiro. Can you please tag the merged commit as version 0.6.2.1 and release it? We are not using version 0.7.x of DropWizard and there is no point maintaining a clone of this repo and hosting a custom version of the artifact internally. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve #8
Updated the GuiceBundle and JerseyContainerModule so that JerseyContainerModule no longer relies on Modules.override to swap the Dropwizard WebApplication for the standard Jersey one. Using Modules.override prevents other ServletModules from being installed in the DI container.
Using inheritance probably isn't the most elegant solution, but I've confirmed that it works, and the Dropwizard resource config is correctly being injected.
I've also confirmed that further ServletModules are correctly being added to the injector.