Migrate VSCE to use local-dev-lib instead of cli-lib #264
Conversation
| @@ -1,5 +1,2 @@ | |||
| #!/bin/sh | |||
| . "$(dirname "$0")/_/husky.sh" | |||
|
|
|||
| node ./scripts/sanityCheckEnLyaml.js | |||
There was a problem hiding this comment.
A little historical context on these lang changes - with cli-lib there was no bundling process and the lyaml files didn't get shipped with the package, so I had set it up to download the lang data on commit to keep it updated and then we could bundle it like this & initialize the data at run time. No longer necessary with local-dev-lib bundling its own lang data so we don't see those failures
| }; | ||
| category: string; | ||
| } | ||
|
|
There was a problem hiding this comment.
This type exists in local-dev-lib now, so changing our usage to that one and removing this. Theres some others I'm sure that we could swap to LDL types but this is just one I specifically noted in the migration checklist
| env, | ||
| }); | ||
| name | ||
| ); |
There was a problem hiding this comment.
updateConfigWithPersonalAccessKey no longer exists in LDL so fetching token first and then using updateConfigWithAccessToken
Hits the couple tasks here: #247
Depends on this PR from local-dev-lib: HubSpot/hubspot-local-dev-lib#134
Diff size is mostly
package-lock.jsonand file removals 馃槃