truncatenumber -> boundedNumber

HubSpot · Jun 21, 2013 · 98a5be8 · 98a5be8
1 parent 1774e90
commit 98a5be8
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 10 deletions.
diff --git a/coffee/src/humanize.coffee b/coffee/src/humanize.coffee
@@ -224,9 +224,7 @@ timeFormats = [
     result += "..." if array.length > length
 
 # Truncates a number to an upper bound.
-@Humanize.truncateNumber = (num, bound, ending) ->
-    bound ?= 100
-    ending ?= "+"
+@Humanize.boundedNumber = (num, bound=100, ending='+') ->
     result = null
 
     if isFinite(num) and isFinite(bound)

diff --git a/coffee/test/test_humanize.spec.coffee b/coffee/test/test_humanize.spec.coffee
@@ -118,11 +118,11 @@ describe 'Truncating objects to shorter versions', ->
         expect(Humanize.truncate(objs.str, 14, '...kidding')).toEqual('abcd...kidding')
 
     it 'should truncate a number to an upper bound', ->
-        expect(Humanize.truncateNumber(objs.num, 500)).toEqual('500+')
+        expect(Humanize.boundedNumber(objs.num, 500)).toEqual('500+')
 
     it 'should not trucate things that are too short', ->
         expect(Humanize.truncate(objs.str, objs.str.length + 1)).toEqual(objs.str)
-        expect(Humanize.truncateNumber(objs.num, objs.num + 1)).toEqual("#{objs.num}")
+        expect(Humanize.boundedNumber(objs.num, objs.num + 1)).toEqual("#{objs.num}")
 
 describe 'Converting a list to a readable, oxford commafied string', ->
     items = ['apple', 'orange', 'banana', 'pear', 'pineapple']

diff --git a/public/dist/humanize.min.js b/public/dist/humanize.min.js
diff --git a/public/src/humanize.js b/public/src/humanize.js
diff --git a/public/test/test_humanize.js b/public/test/test_humanize.js
@@ -130,11 +130,11 @@
       return expect(Humanize.truncate(objs.str, 14, '...kidding')).toEqual('abcd...kidding');
     });
     it('should truncate a number to an upper bound', function() {
-      return expect(Humanize.truncateNumber(objs.num, 500)).toEqual('500+');
+      return expect(Humanize.boundedNumber(objs.num, 500)).toEqual('500+');
     });
     return it('should not trucate things that are too short', function() {
       expect(Humanize.truncate(objs.str, objs.str.length + 1)).toEqual(objs.str);
-      return expect(Humanize.truncateNumber(objs.num, objs.num + 1)).toEqual("" + objs.num);
+      return expect(Humanize.boundedNumber(objs.num, objs.num + 1)).toEqual("" + objs.num);
     });
   });