Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render back unresolved tokens #1072

Closed

Conversation

marius-diumia
Copy link

This change allow to render back tokens which are unresolved.

Default behaviour is:

  • context key = "resolved"
  • template this is {{ key }} but this is {{ missing }}
  • with output this is resolved but this is

Enabling configuration .withRenderBackUnknownTokens(true) the behaviour is:

  • context key = "resolved"
  • template this is {{ key }} but this is {{ missing }}
  • with output this is resolved but this is {{ missing }}

@marius-diumia
Copy link
Author

Hi @jasmith-hs I want to ask you if there is a change to merge my PR in one of the next releases.
Currently I'm using the workaround as you suggested in the issue #1046. But it doesn't cover all the use cases which I need. Problem with this is that it doesn't support filters. I need to be able to maintain the variable not resolved, but in the same time to be able to assign a default. Just updated the unit test which show that use case.
Thanks

@jasmith-hs
Copy link
Contributor

@marius-diumia would you be able change this to use the new Features way of adding flags: #1066, and then I can merge it in for the next release

@abarrafo
Copy link
Contributor

Just opened this pr #1150 leveraging Features..

@abarrafo
Copy link
Contributor

@marius-diumia you can close this out now. Have a look in the test in PR: #1150 for usage. @jasmith-hs what is your release lifecycle? When would we expect this to be in maven-central? Thanks!

@marius-diumia
Copy link
Author

resolved by PR #1150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants